Skip to content

Resolve Event Context Loss in Nested Event Cacnellation #4529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Resolve Event Context Loss in Nested Event Cacnellation #4529

wants to merge 4 commits into from
+90 −19

Conversation

@MohabCodeX
Copy link
Contributor

@MohabCodeX MohabCodeX commented Nov 9, 2025

Problem

When events trigger other events (nested), the parent event would lose its cancellation reason and context.

Solution

Replaced single event context pointer with a proper context stack, each event now maintains its own cancellation state and reason.

Results

Before

[08:30:50] [debug] [testing]\vbug\server.lua:28 - Testing nested events...
[08:30:50] [debug] [testing]\vbug\server.lua:21 - PASS: Event B has its reason
[08:30:50] [debug] [testing]\vbug\server.lua:12 - FAIL: Expected 'Reason A', got ''

After

[08:30:50] [debug] [testing]\vbug\server.lua:28 - Testing nested events...
[08:30:50] [debug] [testing]\vbug\server.lua:21 - PASS: Event B has its reason
[08:30:50] [debug] [testing]\vbug\server.lua:12 - PASS: Event A kept its reason
Testing script 
addEvent("eventA", true)
addEvent("eventB", true)

addEventHandler("eventA", root, function()
    cancelEvent(true, "Reason A")
    triggerEvent("eventB", root)
    
    local reason = getCancelReason()
    if reason == "Reason A" then
        outputDebugString("PASS: Event A kept its reason")
    else
        outputDebugString("FAIL: Expected 'Reason A', got '" .. reason .. "'")
    end
end)

addEventHandler("eventB", root, function()
    cancelEvent(true, "Reason B")
    
    local reason = getCancelReason()
    if reason == "Reason B" then
        outputDebugString("PASS: Event B has its reason")
    else
        outputDebugString("FAIL: Expected 'Reason B', got '" .. reason .. "'")
    end
end)

addCommandHandler("testevent", function()
    outputDebugString("Testing nested events...")
    triggerEvent("eventA", root)
end)

@MohabCodeX MohabCodeX marked this pull request as draft November 9, 2025 07:50
@MohabCodeX MohabCodeX marked this pull request as ready for review November 10, 2025 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@MohabCodeX